Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Subject Segmentation #697

Merged
merged 29 commits into from
Oct 7, 2024
Merged

feat: Subject Segmentation #697

merged 29 commits into from
Oct 7, 2024

Conversation

bensonarafat
Copy link
Collaborator

fbernaly and others added 29 commits September 3, 2024 12:41
* develop:
  chore: Update example app dependencies

# Conflicts:
#	packages/example/android/app/build.gradle
* develop:
  chore(deps): bump actions/checkout from 4.1.7 to 4.2.0 (#683)
  chore(deps): bump actions/setup-java from 4.3.0 to 4.4.0 (#682)
  chore: bug report template
  chore: Release updated
  chore: Update dependencies android (#671)
  chore(deps): bump actions/setup-java from 4.2.2 to 4.3.0 (#674)

# Conflicts:
#	packages/example/ios/Podfile.lock
#	packages/example/pubspec.lock
* develop:
  chore: Update dev dependencies and example app
  chore: Update iOS dependencies (#693)

# Conflicts:
#	README.md
#	packages/example/ios/Podfile.lock
#	packages/example/pubspec.lock
* develop:
  chore(deps): bump actions/checkout from 4.2.0 to 4.2.1 (#696)
  chore: Update dev dependencies and example app
@fbernaly fbernaly merged commit c27ac07 into develop Oct 7, 2024
3 checks passed
@fbernaly fbernaly deleted the test branch October 7, 2024 23:03
Copy link

@giora-gymijet giora-gymijet Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @bensonarafat @fbernaly, the filename should be
GoogleMlKitSubjectionSegmentationPlugin.h (capital K in in Kit)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giora-gymijet for catching that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants