-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package_info_plus): migrate to pkg:web from dart:html #2316
Conversation
CC @vbuberen |
Thanks for your contribution. |
This now aligns with the latest stable SDK released on Wednesday. |
I have seen the release, but not all projects update that fast. I would like to not release a breaking version of the plugin now. |
Understood. But isn't this package pretty stable? Are you expecting a lot of changes? This unblocks our wasm experiments because we have an app that depends on If folks using old SDKS don't get the LATEST for a while, does it cause problems? |
I am expecting lots of users who can't/don't want to read changelogs starting opening issues in the repo and complaining. Really don't want to deal with it now, like it was recently where lots of people couldn't update their iOS deployment target to 12 as it was required by |
To be clear about timelines - it is not months, but a few weeks. |
🙏 Thanks! |
e16b221
to
9031791
Compare
Due to another PR that was also a breaking change I would like to combine both of breaking changes and release only one major version bump this week. Thus, will release changes from this PR this week as well. |
Thank you! |
@kevmoo Do I need to migrate dart:html to package:web to allow using Wasm? or it will be automatic? |
I think this is not the right place for such discussion, but here is the place you should check for info on WASM support |
@vbuberen Thanks for clarification |
Description
Change from using
dart:html
topackage:web
. This will allow this plugin to be used from Wasm.Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).