Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package_info_plus): migrate to pkg:web from dart:html #2316

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 30, 2023

Description

Change from using dart:html to package:web. This will allow this plugin to be used from Wasm.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@kevmoo kevmoo changed the title package_info_plus: migrate web to pkg:web fix: package_info_plus: migrate web to pkg:web Oct 30, 2023
@kevmoo kevmoo marked this pull request as ready for review November 16, 2023 22:17
@kevmoo kevmoo changed the title fix: package_info_plus: migrate web to pkg:web fix(package_info_plus): migrate web to pkg:web Nov 16, 2023
@kevmoo kevmoo changed the title fix(package_info_plus): migrate web to pkg:web fix(package_info_plus): migrate to pkg:web from dart:html Nov 16, 2023
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 16, 2023

CC @vbuberen

@vbuberen
Copy link
Collaborator

Thanks for your contribution.
Too bad that min Dart is that high now. I would postpone this PR a bit.

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 17, 2023

Thanks for your contribution. Too bad that min Dart is that high now. I would postpone this PR a bit.

This now aligns with the latest stable SDK released on Wednesday.

@vbuberen
Copy link
Collaborator

This now aligns with the latest stable SDK released on Wednesday.

I have seen the release, but not all projects update that fast. I would like to not release a breaking version of the plugin now.

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 17, 2023

This now aligns with the latest stable SDK released on Wednesday.

I have seen the release, but not all projects update that fast. I would like to not release a breaking version of the plugin now.

Understood.

But isn't this package pretty stable? Are you expecting a lot of changes?

This unblocks our wasm experiments because we have an app that depends on package_info_plus.

If folks using old SDKS don't get the LATEST for a while, does it cause problems?

@vbuberen
Copy link
Collaborator

But isn't this package pretty stable? Are you expecting a lot of changes?

I am expecting lots of users who can't/don't want to read changelogs starting opening issues in the repo and complaining. Really don't want to deal with it now, like it was recently where lots of people couldn't update their iOS deployment target to 12 as it was required by connectivity_plus release. It is a time waste for now, so I would prefer to merge and release it later when have more time and more codebases adopt Dart 3.x.

@vbuberen
Copy link
Collaborator

To be clear about timelines - it is not months, but a few weeks.

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 18, 2023

To be clear about timelines - it is not months, but a few weeks.

🙏 Thanks!

@vbuberen
Copy link
Collaborator

vbuberen commented Nov 20, 2023

Due to another PR that was also a breaking change I would like to combine both of breaking changes and release only one major version bump this week. Thus, will release changes from this PR this week as well.

@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 20, 2023

Thank you!

@vbuberen vbuberen merged commit 450aeb5 into fluttercommunity:main Nov 20, 2023
20 checks passed
@kevmoo kevmoo deleted the pkg_web_wip branch November 20, 2023 21:22
@amrgetment
Copy link

@kevmoo Do I need to migrate dart:html to package:web to allow using Wasm? or it will be automatic?

@vbuberen
Copy link
Collaborator

I think this is not the right place for such discussion, but here is the place you should check for info on WASM support
https://docs.flutter.dev/platform-integration/web/wasm

@amrgetment
Copy link

@vbuberen Thanks for clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants