Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package_info_plus): change deprecated web/helpers to web/web import #2693

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore(package_info_plus): change deprecated web/helpers to web/web import #2693

merged 1 commit into from
Mar 14, 2024

Conversation

OutdatedGuy
Copy link
Contributor

Description

As suggested by the package:web/helpers.dart that it is deprecated and package:web/web.dart should be used instead as both these files export the same thing.

They do not pose any issue while using the package, but while fixing another issue in one of the packages I saw these linting warnings and thought of fixing them.

Related Issues

Trivial changes so doesn't need an issue.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran changed the title chore(package_info_plus): removed use of deprecated dependencies chore(package_info_plus): change deprecated web/helpers to web/web import Mar 14, 2024
@miquelbeltran miquelbeltran merged commit ef4f15f into fluttercommunity:main Mar 14, 2024
20 of 21 checks passed
@miquelbeltran
Copy link
Member

Thanks! This should be fine as the minimum web package version supported is 0.5

@OutdatedGuy OutdatedGuy deleted the chore/update-dependencies branch March 15, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants