shell/oom: log more detail when tasks are killed #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: when a job exceeds the memory cgroup limit, it may not be obvious what the limit is or what host it occurred on. Include the hostname with the existing "out of memory" message. Log the value of memory.peak (the peak memory usage).
|
Thanks - I'll set MWP. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6289 +/- ##
==========================================
- Coverage 83.34% 83.33% -0.02%
==========================================
Files 522 522
Lines 86036 86057 +21
==========================================
+ Hits 71710 71717 +7
- Misses 14326 14340 +14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when a job exceeds the memory cgroup limit, it may not be immediately obvious what the limit is or what host it occurred on.
Include the hostname with the existing "out of memory" message. Log the value of memory.peak (the peak memory usage).
New output example