fix IDEA warnings "Unnecessary call to 'toString()'"

flyingsaucerproject · Sep 17, 2023 · 5e3e11c · 5e3e11c
1 parent bb8ebfc
commit 5e3e11c
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 11 deletions.
diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/css/constants/IdentValue.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/css/constants/IdentValue.java
@@ -316,7 +316,7 @@ public FSColor asColor() {
     public float getFloatProportionalTo(CSSName cssName,
                                         float baseValue,
                                         CssContext ctx) {
-        throw new XRRuntimeException("Ident value (" + toString() + ") is never a length; wrong class used for derived value.");
+        throw new XRRuntimeException("Ident value (" + this + ") is never a length; wrong class used for derived value.");
     }
 
     public String asString() {

diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/css/parser/MakeTokens.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/css/parser/MakeTokens.java
@@ -88,6 +88,6 @@ public static final void main(String[] args) throws IOException {
 
         buf.append(EOL);
 
-        System.out.println(buf.toString());
+        System.out.println(buf);
     }
 }
diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/layout/TextUtil.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/layout/TextUtil.java
@@ -163,7 +163,7 @@ private static String capitalizeWords( String text ) {
 
         //Uu.p("final = -"+sb.toString()+"-");
         if ( sb.toString().length() != text.length() ) {
-            Uu.p( "error! to strings arent the same length = -" + sb.toString() + "-" + text + "-" );
+            Uu.p( "error! to strings arent the same length = -" + sb + "-" + text + "-" );
         }
         return sb.toString();
     }

diff --git a/flying-saucer-core/src/main/java/org/xhtmlrenderer/swing/HTMLTest.java b/flying-saucer-core/src/main/java/org/xhtmlrenderer/swing/HTMLTest.java
@@ -159,10 +159,8 @@ public void run() {
                     panel.setDocument(url.toExternalForm());
 
                     long el = System.currentTimeMillis() - st;
-                    XRLog.general("loadDocument(" + url.toString() + ") in " + el + "ms, render may take longer");
-                    HTMLTest.this.setTitle(BASE_TITLE + "-  " +
-                            panel.getDocumentTitle() + "  " +
-                            "(" + url.toString() + ")");
+                    XRLog.general("loadDocument(" + url + ") in " + el + "ms, render may take longer");
+                    HTMLTest.this.setTitle(String.format("%s-  %s  (%s)", BASE_TITLE, panel.getDocumentTitle(), url));
                 } catch (Exception ex) {
                     Uu.p(ex);
                 }

diff --git a/flying-saucer-examples/src/main/java/FontGlyphTableRender.java b/flying-saucer-examples/src/main/java/FontGlyphTableRender.java
@@ -246,7 +246,7 @@ private String getITextFontFamilyName(File selFile) {
                 selFile.getPath(),
                 BaseFont.IDENTITY_H,
                 BaseFont.EMBEDDED);
-        System.out.println("All family names reported by iText for " + selFile.getPath() + ": " + set.toString());
+        System.out.println("All family names reported by iText for " + selFile.getPath() + ": " + set);
         return (String) set.iterator().next();
     }
 

diff --git a/flying-saucer-examples/src/main/java/org/xhtmlrenderer/demo/browser/BrowserPanel.java b/flying-saucer-examples/src/main/java/org/xhtmlrenderer/demo/browser/BrowserPanel.java
@@ -441,14 +441,14 @@ private String addLineBreaks(String _text, int maxLineLength) {
 
             final char c = _text.charAt(i);
             if (needBreak && Character.isWhitespace(c)) {
-                System.out.println("Breaking: " + broken.toString());
+                System.out.println("Breaking: " + broken);
                 needBreak = false;
                 broken.append('\n');
             } else {
                 broken.append(c);
             }
         }
-        System.out.println("Broken! " + broken.toString());
+        System.out.println("Broken! " + broken);
         return broken.toString();
     }
 

diff --git a/flying-saucer-swt/src/main/java/org/xhtmlrenderer/swt/SWTFontResolver.java b/flying-saucer-swt/src/main/java/org/xhtmlrenderer/swt/SWTFontResolver.java
@@ -119,7 +119,7 @@ public FSFont resolveFont(SharedContext renderingContext, FontSpecification spec
             return font;
         }
 
-        XRLog.cascade(Level.WARNING, "Falling back to default system font. " + spec.toString());
+        XRLog.cascade(Level.WARNING, "Falling back to default system font. " + spec);
 
         // last resort: use system font
         return _system_font;