Improve table layout #185
Draft
Improve table layout #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndrejSpanel
force-pushed
the
improve_table_layout
branch
from
d3701a6
to
677ce79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to improve layouting for tables. In particular I want to be able to use tables so that one row uses all available space not used by the others. At the moment, when I tell table to use 100% of the height, it is always the last table row which get all space not used by previous rows.
Individual rows accept absolute dimensions (px or em), but relative dimensions, like 50% or 100% are ignored.
I guess classes which need adjusting are perhaps
TableRowBoxandTableCellBox.Would you give me any hints how can be a task like this acomplished, or if there is something similar done in other areas of Flying Saucer?
In this PR I have added two examples demonstrating the issue, using different ways how to create the tables, both with the same result: