Fix code warnings

flying-saucer-core/src/main/java/org/xhtmlrenderer/css/extend/TreeResolver.java

@@ -19,6 +19,7 @@
  */
 package org.xhtmlrenderer.css.extend;
 
+import com.google.errorprone.annotations.CheckReturnValue;
 import org.w3c.dom.Node;
 
 /**
@@ -62,6 +63,7 @@ public interface TreeResolver {
      * @param element The node
      * @return -1 in case of error, 0 indexed position otherwise
      */
+    @CheckReturnValue
     int getPositionOfElement(Node element);
 
     /**

flying-saucer-core/src/main/java/org/xhtmlrenderer/css/newmatch/Condition.java

@@ -476,7 +476,7 @@ private static class OddChildCondition extends Condition {
         @Override
         boolean matches(Node e, AttributeResolver attRes, TreeResolver treeRes) {
             int position = treeRes.getPositionOfElement(e);
-            return position >= 0 && position % 2 == 1;
+            return position % 2 == 1;
         }
     }
 

flying-saucer-core/src/main/java/org/xhtmlrenderer/css/parser/CSSParseException.java

@@ -24,8 +24,7 @@
 public class CSSParseException extends RuntimeException {
     @Nullable
     private final Token _found;
-    @Nullable
-    private final Token[] _expected;
+    private final Token @Nullable [] _expected;
     private int _line;
 
     @Nullable
@@ -52,7 +51,7 @@ public CSSParseException(Token found, Token expected, int line) {
         _genericMessage = null;
     }
 
-    public CSSParseException(Token found, @Nullable Token[] expected, int line) {
+    public CSSParseException(Token found, Token @Nullable [] expected, int line) {
         _found = found;
         _expected = expected == null ? new Token[]{} : expected.clone();
         _line = line;

flying-saucer-core/src/main/java/org/xhtmlrenderer/css/parser/property/PrimitivePropertyBuilders.java

@@ -962,7 +962,7 @@ public List<PropertyDeclaration> buildDeclarations(
 
             String text = concat(normalized, ',');
             PropertyValue result = new PropertyValue(
-                    CSSPrimitiveValue.CSS_STRING, text, text, normalized.toArray(new String[normalized.size()]), null);  // HACK cssText can be wrong
+                    CSSPrimitiveValue.CSS_STRING, text, text, normalized.toArray(new String[0]), null);  // HACK cssText can be wrong
 
             return singletonList(
                     new PropertyDeclaration(cssName, result, important, origin));

flying-saucer-examples/src/main/java/org/xhtmlrenderer/demo/browser/BrowserPanel.java

@@ -52,6 +52,8 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
+import static java.util.Objects.requireNonNull;
+
 public final class BrowserPanel extends JPanel implements DocumentListener {
     private static final org.slf4j.Logger log = LoggerFactory.getLogger(BrowserPanel.class);
     private static final Logger logger = Logger.getLogger("app.browser");
@@ -145,7 +147,7 @@ private void loadCustomFonts() {
         SharedContext rc = view.getSharedContext();
         try {
             rc.setFontMapping("Fuzz", Font.createFont(Font.TRUETYPE_FONT,
-                    new DemoMarker().getClass().getResourceAsStream("/demos/fonts/fuzz.ttf")));
+                    requireNonNull(DemoMarker.class.getResourceAsStream("/demos/fonts/fuzz.ttf"))));
         } catch (Exception ex) {
             Uu.p(ex);
         }

flying-saucer-swt/src/main/java/org/xhtmlrenderer/swt/SWTOutputDevice.java

@@ -299,7 +299,7 @@ public void setStroke(Stroke s) {
             case BasicStroke.CAP_BUTT -> SWT.CAP_FLAT;
             case BasicStroke.CAP_ROUND -> SWT.CAP_ROUND;
             case BasicStroke.CAP_SQUARE -> SWT.CAP_SQUARE;
-            default -> SWT.CAP_SQUARE;
+            default -> throw new IllegalArgumentException("Unsupported CAP value: " + bs.getEndCap());
         };
         _gc.setLineCap(gcCap);
 
@@ -308,7 +308,7 @@ public void setStroke(Stroke s) {
             case BasicStroke.JOIN_BEVEL -> SWT.JOIN_BEVEL;
             case BasicStroke.JOIN_MITER -> SWT.JOIN_MITER;
             case BasicStroke.JOIN_ROUND -> SWT.JOIN_ROUND;
-            default -> SWT.JOIN_MITER;
+            default -> throw new IllegalArgumentException("Unsupported line join: " + bs.getLineJoin());
         };
         _gc.setLineJoin(gcJoin);