Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

feat(Features/Templates): remove template configs #293

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(Features/Templates): remove template configs #293

wants to merge 1 commit into from

Conversation

domtra
Copy link
Member

@domtra domtra commented Nov 28, 2018

No description provided.

@domtra domtra requested review from steffenbew and dgrdl November 28, 2018 00:22
dgrdl
dgrdl approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@dgrdl dgrdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, always preferred less JSON configs anyways. If you decide to merge, please make sure to add BREAKING CHANGE with a description to the merge commit. Unless you consider this a non-breaking change?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgrdl dgrdl dgrdl approved these changes

@steffenbew steffenbew steffenbew approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domtra @steffenbew @dgrdl