Update ads1x15.py #329
Merged
Update ads1x15.py #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids race condition when reading a channel
|
I'm using ads1115 on my RPI4 and if I configure more that one channel - mqtt-io seems to crash after some time. When running with only one channel - everything works perfectly. So hopefully this will fix this problem. Another way of achieving this could be by setting max_workers=1 on this module's ThreadPoolExecutor object |
Avoids race condition when reading a channel
Formatting with Lint
|
I tested this version with all 4 channels enabled - it is running fine for more than day now and not crashing as before. Would be great if this fix could be included in the main branch of mqtt-io |
|
@flyte Happy New Year ;-) Any time to include this PR and make a new version? Would be great, since this is really an important Bugfix when using an ads1x15 |
Bluscream
added a commit
to Bluscream/mqtt-io
that referenced
this pull request
Jan 13, 2024
Update ads1x15.py (flyte#329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids race condition when reading a channel