Add default values

Signed-off-by: davidmirror-ops <david.espejo@union.ai>

charts/flyte-core/README.md

@@ -74,6 +74,7 @@ helm install gateway bitnami/contour -n flyte
 | common.databaseSecret.name | string | `""` | Specify name of K8s Secret which contains Database password. Leave it empty if you don't need this Secret |
 | common.databaseSecret.secretManifest | object | `{}` | Specify your Secret (with sensitive data) or pseudo-manifest (without sensitive data). See https://github.com/godaddy/kubernetes-external-secrets |
 | common.flyteNamespaceTemplate.enabled | bool | `false` | - Enable or disable creating Flyte namespace in template. Enable when using helm as template-engine only. Disable when using `helm install ...`. |
+|common.ingress.ingressClassName | string | `""` |
 | common.ingress.albSSLRedirect | bool | `false` | - albSSLRedirect adds a special route for ssl redirect. Only useful in combination with the AWS LoadBalancer Controller. |
 | common.ingress.annotations | object | `{"nginx.ingress.kubernetes.io/app-root":"/console"}` | - Ingress annotations applied to both HTTP and GRPC ingresses. |
 | common.ingress.enabled | bool | `true` | - Enable or disable creating Ingress for Flyte. Relevant to disable when using e.g. Istio as ingress controller. |

charts/flyte-core/values-eks.yaml

@@ -132,12 +132,12 @@ flyteconsole:
 
 common:
   ingress:
+    ingressClassName: alb
     albSSLRedirect: true
     separateGrpcIngress: true
     annotations:
       # -- aws-load-balancer-controller v2.1 or higher is required - https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/
       # For EKS if using [ALB](https://kubernetes-sigs.github.io/aws-load-balancer-controller/guide/ingress/annotations/), these annotations are set
-      kubernetes.io/ingress.class: alb
       alb.ingress.kubernetes.io/tags: service_instance=production
       alb.ingress.kubernetes.io/scheme: internet-facing
       alb.ingress.kubernetes.io/target-type: ip 

charts/flyte-core/values-gcp.yaml

@@ -150,11 +150,11 @@ workflow_notifications:
 
 common:
   ingress:
+    ingressClassName: nginx
     host: "{{ .Values.userSettings.hostName }}"
     tls:
       enabled: true
     annotations:
-      kubernetes.io/ingress.class: nginx
       nginx.ingress.kubernetes.io/ssl-redirect: "true"
       cert-manager.io/issuer: "letsencrypt-production"
     # --- separateGrpcIngress puts GRPC routes into a separate ingress if true. Required for certain ingress controllers like nginx.

charts/flyte-core/values.yaml

@@ -382,6 +382,9 @@ common:
   ingress:
     # --- Enable or disable creating Ingress for Flyte. Relevant to disable when using e.g. Istio as ingress controller.
     enabled: true
+    # --- Specify the IngressClass corresponding to your Ingress controller. This is useful for automated certificate generation, among other use cases. 
+    # --- https://kubernetes.io/docs/concepts/services-networking/ingress-controllers/#using-multiple-ingress-controllers
+    ingressClassName: ""
     # --- Enable or disable HMR route to flyteconsole. This is useful only for frontend development.
     webpackHMR: false
     # --- separateGrpcIngress puts GRPC routes into a separate ingress if true. Required for certain ingress controllers like nginx.