Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to run golangci-lint locally #6134

Closed
2 tasks done
Sovietaced opened this issue Jan 3, 2025 · 1 comment
Closed
2 tasks done

[BUG] Unable to run golangci-lint locally #6134

Sovietaced opened this issue Jan 3, 2025 · 1 comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@Sovietaced
Copy link
Contributor

Sovietaced commented Jan 3, 2025

Describe the bug

~/code/flyte/flyteadmin git:[rbac-poc]
make lint-fix
Makefile:37: warning: overriding commands for target `k8s_integration_execute'
../boilerplate/flyte/end2end/Makefile:18: warning: ignoring old commands for target `k8s_integration_execute'
Makefile:19: warning: overriding commands for target `generate'
../boilerplate/flyte/golang_test_targets/Makefile:14: warning: ignoring old commands for target `generate'
Makefile:31: warning: overriding commands for target `test_unit_codecov'
../boilerplate/flyte/golang_test_targets/Makefile:55: warning: ignoring old commands for target `test_unit_codecov'
mkdir -p ./bin
go build -o pflags ./cli/pflags/main.go && mv ./pflags ./bin
Using temp directory /var/folders/h0/cm6xy2g1463675c79_kb76l40000gn/T/gotooling-XXX.uczXz7WLFQ
/var/folders/h0/cm6xy2g1463675c79_kb76l40000gn/T/gotooling-XXX.uczXz7WLFQ ~/code/flyte/flyteadmin
Installing github.com/EngHabu/mockery/cmd/mockery
Renaming mockery to mockery-fork
Installing github.com/vektra/mockery/v2@v2.40.3
Renaming mockery to mockery-v2
Installing github.com/golangci/golangci-lint/cmd/golangci-lint
Installing github.com/daixiang0/gci
Installing github.com/alvaroloes/enumer
Installing github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc
Renaming mockery-fork to mockery
~/code/flyte/flyteadmin
GL_DEBUG=linters_output,env golangci-lint run --fix --timeout=5m --exclude deprecated -v
make: *** [lint] Killed: 9

This appears to be related to how golangci-lint detects go versions and may be fixed in a new version which I am going to test out.

Expected behavior

golangci-lint does not get killed

Additional context to reproduce

Running in a goland terminal.

~/code/flyte/flyteadmin git:[rbac-poc]
go version
go version go1.22.0 darwin/arm64

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Sovietaced Sovietaced added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jan 3, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Flyte Issues/PRs maintenance Jan 3, 2025
@Sovietaced Sovietaced reopened this Jan 3, 2025
@Sovietaced
Copy link
Contributor Author

This seems to be resolved when I drop other delete other go versions from my system hmmm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Done
Development

No branches or pull requests

1 participant