Print K8s Resolver Event for Agent Grpc request debugging #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Code Review Agent Run #37ddb4Actionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6146 +/- ##
=======================================
Coverage 37.01% 37.02%
=======================================
Files 1317 1317
Lines 132523 132534 +11
=======================================
+ Hits 49060 49066 +6
- Misses 79217 79221 +4
- Partials 4246 4247 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
reviewed
Jan 9, 2025
flytestdlib/resolver/k8s_resolver.go
Outdated
| @@ -166,6 +177,11 @@ func (k *kResolver) run() { | |||
| case <-k.ctx.Done(): | |||
| return | |||
| case event, ok := <-watcher.ResultChan(): | |||
| logger.Info(k.ctx, "k8s resolver watchet event response: [%v]", event) | |||
There was a problem hiding this comment.
Will it print the event.Object? If so, I think we can remove line 181 and 182
Code Review Agent Run #6076daActionable Suggestions - 0Review Details
AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
Why are the changes needed?
k8s resolver might fail if we set the wrong deployment endpoint for
agent service, print what error happened will be super helpful.What changes were proposed in this pull request?
print service namespace, service name, and response event.
How was this patch tested?
build a propeller image and tested in private cluster.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Enhanced Kubernetes resolver logging in Flyte standard library by implementing detailed error logging for watcher creation failures and adding comprehensive logging for Kubernetes watcher events. Added service namespace and service name details to log messages, fixed typos, and removed redundant log statements for more concise and accurate debug information. The changes improve debugging capabilities by providing visibility into event responses, object details, and object kinds.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1