Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support failure node #4308

Merged
merged 24 commits into from
Dec 9, 2023

Merge branch 'master' of github.com:flyteorg/flyte into failure_node

d6b4b1d
Select commit
Loading
Failed to load commit list.
Merged

Add support failure node #4308

Merge branch 'master' of github.com:flyteorg/flyte into failure_node
d6b4b1d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 8, 2023 in 0s

59.45% (+0.53%) compared to f440278

View this Pull Request on Codecov

59.45% (+0.53%) compared to f440278

Details

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (f440278) 58.92% compared to head (d6b4b1d) 59.45%.
Report is 1 commits behind head on master.

❗ Current head d6b4b1d differs from pull request most recent head e23ece2. Consider uploading reports for the commit e23ece2 to get more accurate results

Files Patch % Lines
...er/pkg/controller/nodes/subworkflow/subworkflow.go 0.00% 11 Missing ⚠️
flytepropeller/pkg/controller/workflow/executor.go 68.18% 7 Missing ⚠️
...peller/pkg/controller/nodes/subworkflow/handler.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
+ Coverage   58.92%   59.45%   +0.53%     
==========================================
  Files         620      639      +19     
  Lines       52432    54000    +1568     
==========================================
+ Hits        30896    32107    +1211     
- Misses      19071    19362     +291     
- Partials     2465     2531      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.