Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] correctly set task execution phase for terminal array node #5136

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+25 −5

Merge branch 'master' into bug/arraynode-terminal-eventing

6cc769f
Select commit
Loading
Failed to load commit list.
Open

[Bug] correctly set task execution phase for terminal array node #5136

Merge branch 'master' into bug/arraynode-terminal-eventing
6cc769f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 10, 2025 in 0s

26.31% of diff hit (target 37.02%)

View this Pull Request on Codecov

26.31% of diff hit (target 37.02%)

Annotations

Check warning on line 134 in flytepropeller/pkg/controller/nodes/array/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/array/handler.go#L132-L134 

Added lines #L132 - L134 were not covered by tests

Check warning on line 478 in flytepropeller/pkg/controller/nodes/array/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/array/handler.go#L475-L478 

Added lines #L475 - L478 were not covered by tests

Check warning on line 629 in flytepropeller/pkg/controller/nodes/array/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/array/handler.go#L626-L629 

Added lines #L626 - L629 were not covered by tests
View more details on Codecov