Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using domain-qualified finalizers #6023

Merged
merged 3 commits into from
Jan 4, 2025

chore: use flyte.org/finalizer instead

202cce9
Select commit
Loading
Failed to load commit list.
Merged

chore: using domain-qualified finalizers #6023

chore: use flyte.org/finalizer instead
202cce9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2024 in 0s

36.99% (-0.04%) compared to d1a723e

View this Pull Request on Codecov

36.99% (-0.04%) compared to d1a723e

Details

Codecov Report

Attention: Patch coverage is 53.65854% with 19 lines in your changes missing coverage. Please review.

Project coverage is 36.99%. Comparing base (d1a723e) to head (202cce9).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
flyteplugins/go/tasks/plugins/array/k8s/subtask.go 0.00% 12 Missing and 1 partial ⚠️
...er/pkg/controller/nodes/task/k8s/plugin_manager.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6023      +/-   ##
==========================================
- Coverage   37.03%   36.99%   -0.04%     
==========================================
  Files        1313     1317       +4     
  Lines      131622   132471     +849     
==========================================
+ Hits        48742    49006     +264     
- Misses      78652    79210     +558     
- Partials     4228     4255      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov