Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint version #6135

Closed
wants to merge 2 commits into from

Conversation

Sovietaced
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Signed-off-by: Jason Parraga <sovietaced@gmail.com>
@Sovietaced Sovietaced closed this Jan 3, 2025
@Sovietaced Sovietaced deleted the issue-6134 branch January 3, 2025 22:01
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (fd9a378) to head (d7e7262).

Files with missing lines Patch % Lines
flyteadmin/pkg/errors/errors.go 0.00% 2 Missing ⚠️
...yteadmin/pkg/repositories/transformers/workflow.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fd9a378) and HEAD (d7e7262). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (fd9a378) HEAD (d7e7262)
unittests-flytestdlib 1 0
unittests-flyteplugins 1 0
unittests-flytepropeller 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6135      +/-   ##
==========================================
- Coverage   37.01%   29.60%   -7.42%     
==========================================
  Files        1318      681     -637     
  Lines      132525    78252   -54273     
==========================================
- Hits        49058    23163   -25895     
+ Misses      79222    53172   -26050     
+ Partials     4245     1917    -2328     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.25% <0.00%> (-0.01%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.33% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins ?
unittests-flytepropeller ?
unittests-flytestdlib ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at eduardo@union.ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants