Upgrade golangci-lint version

boilerplate/flyte/golangci_file/.golangci.yml

@@ -10,25 +10,21 @@ run:
 linters:
   disable-all: true
   enable:
-    - deadcode
     - errcheck
     - gas
     - gci
     - goconst
     - goimports
-    - golint
     - gosimple
     - govet
     - ineffassign
     - misspell
     - nakedret
     - staticcheck
-    - structcheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
 
 linters-settings:
   gci:

datacatalog/.golangci.yml

@@ -28,6 +28,9 @@ linters-settings:
       - default
       - prefix(github.com/flyteorg)
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
   goconst:
     ignore-tests: true
 issues:

flyteadmin/.golangci.yml

@@ -30,6 +30,9 @@ linters-settings:
       - default
       - prefix(github.com/flyteorg)
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
   goconst:
     ignore-tests: true
 issues:

flyteadmin/pkg/async/schedule/aws/workflow_executor.go

@@ -129,7 +129,6 @@ func generateExecutionName(launchPlan *admin.LaunchPlan, kickoffTime time.Time)
 		Name:    launchPlan.GetId().GetName(),
 	})
 	randomSeed := kickoffTime.UnixNano() + int64(hashedIdentifier) // #nosec G115
-
 	return common.GetExecutionName(randomSeed)
 }
 

flyteadmin/pkg/errors/errors.go

@@ -91,7 +91,7 @@ func NewAlreadyInTerminalStateError(ctx context.Context, errorMsg string, curPha
 	statusErr, transformationErr := NewFlyteAdminError(codes.FailedPrecondition, errorMsg).WithDetails(reason)
 	if transformationErr != nil {
 		logger.Panicf(ctx, "Failed to wrap grpc status in type 'Error': %v", transformationErr)
-		return NewFlyteAdminErrorf(codes.FailedPrecondition, errorMsg)  //nolint
+		return NewFlyteAdminErrorf(codes.FailedPrecondition, errorMsg) //nolint
 	}
 	return statusErr
 }
@@ -106,7 +106,7 @@ func NewIncompatibleClusterError(ctx context.Context, errorMsg, curCluster strin
 	})
 	if transformationErr != nil {
 		logger.Panicf(ctx, "Failed to wrap grpc status in type 'Error': %v", transformationErr) //nolint
-		return NewFlyteAdminErrorf(codes.FailedPrecondition, errorMsg) //nolint
+		return NewFlyteAdminErrorf(codes.FailedPrecondition, errorMsg)                          //nolint
 	}
 	return statusErr
 }

flyteadmin/pkg/repositories/transformers/workflow.go

@@ -54,7 +54,7 @@ func FromWorkflowModel(workflowModel models.Workflow) (admin.Workflow, error) {
 	if len(workflowModel.TypedInterface) > 0 {
 		err = proto.Unmarshal(workflowModel.TypedInterface, &workflowInterface)
 		if err != nil {
-			return admin.Workflow{}, errors.NewFlyteAdminErrorf(codes.Internal, fmt.Sprintf("failed to unmarshal workflow %v interface. Error message: %v", workflowModel.ID, err.Error()))  //nolint
+			return admin.Workflow{}, errors.NewFlyteAdminErrorf(codes.Internal, fmt.Sprintf("failed to unmarshal workflow %v interface. Error message: %v", workflowModel.ID, err.Error())) //nolint
 		}
 	}
 

flytecopilot/.golangci.yml

@@ -28,5 +28,8 @@ linters-settings:
       - default
       - prefix(github.com/flyteorg)
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
   goconst:
     ignore-tests: true

flytectl/.golangci.yml

@@ -20,11 +20,16 @@ linters:
     - unparam
     - unused
     - protogetter
+
 linters-settings:
   gci:
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
   goconst:
     ignore-tests: true
+
 issues:
   exclude:
     - copylocks

flyteplugins/.golangci.yml

@@ -28,6 +28,9 @@ linters-settings:
       - default
       - prefix(github.com/flyteorg)
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
 issues:
   exclude:
     - copylocks

flyteplugins/go/tasks/plugins/array/k8s/management.go

@@ -2,11 +2,12 @@
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"time"
 
 	idlCore "github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core"
-	"github.com/flyteorg/flyte/flyteplugins/go/tasks/errors"
+	flyteErrors "github.com/flyteorg/flyte/flyteplugins/go/tasks/errors"
 	"github.com/flyteorg/flyte/flyteplugins/go/tasks/logs"
 	"github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/core"
 	"github.com/flyteorg/flyte/flyteplugins/go/tasks/pluginmachinery/io"
@@ -131,7 +132,7 @@
 	if err != nil {
 		return currentState, externalResources, err
 	} else if taskTemplate == nil {
-		return currentState, externalResources, errors.Errorf(errors.BadTaskSpecification, "Required value not set, taskTemplate is nil")
+		return currentState, externalResources, flyteErrors.Errorf(flyteErrors.BadTaskSpecification, "Required value not set, taskTemplate is nil")
 	}
 
 	arrayJob, err := arrayCore.ToArrayJob(taskTemplate.GetCustom(), taskTemplate.GetTaskTypeVersion())
@@ -355,7 +356,7 @@
 	if err != nil {
 		return currentState, externalResources, err
 	} else if taskTemplate == nil {
-		return currentState, externalResources, errors.Errorf(errors.BadTaskSpecification, "Required value not set, taskTemplate is nil")
+		return currentState, externalResources, flyteErrors.Errorf(flyteErrors.BadTaskSpecification, "Required value not set, taskTemplate is nil")
 	}
 
 	messageCollector := errorcollector.NewErrorMessageCollector()

flyteplugins/go/tasks/plugins/array/k8s/management_test.go

@@ -350,7 +350,7 @@ func TestCheckSubTasksState(t *testing.T) {
 
 		detailed := arrayCore.NewPhasesCompactArray(uint(subtaskCount)) // #nosec G115
 		for i := 0; i < subtaskCount; i++ {
-			detailed.SetItem(i, bitarray.Item(core.PhaseRetryableFailure)) // set all tasks to core.PhaseRetryableFailure
+			detailed.SetItem(i, bitarray.Item(core.PhaseRetryableFailure)) // #nosec G115 set all tasks to core.PhaseRetryableFailure
 		}
 
 		retryAttemptsArray, err := bitarray.NewCompactArray(uint(subtaskCount), bitarray.Item(1)) // #nosec G115
@@ -523,7 +523,7 @@ func TestCheckSubTasksState(t *testing.T) {
 		// #nosec G115
 		detailed := arrayCore.NewPhasesCompactArray(uint(subtaskCount))
 		for i := 0; i < subtaskCount; i++ {
-			detailed.SetItem(i, bitarray.Item(core.PhaseRunning)) // set all tasks to core.PhaseRunning
+			detailed.SetItem(i, bitarray.Item(core.PhaseRunning)) // #nosec G115 set all tasks to core.PhaseRunning
 		}
 
 		// #nosec G115

flytepropeller/.golangci.yml

@@ -28,8 +28,12 @@ linters-settings:
       - default
       - prefix(github.com/flyteorg)
     skip-generated: true
+  gosec:
+    excludes:
+      - G601 # disable the rule G601 since its not relevant in go 1.22+
   goconst:
     ignore-tests: true
 issues:
   exclude:
     - copylocks
+

flytepropeller/pkg/controller/nodes/array/handler.go

@@ -20,7 +20,7 @@ import (
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/config"
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/executors"
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/common"
-	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/errors"
+	flyteErrors "github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/errors"
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/handler"
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/interfaces"
 	"github.com/flyteorg/flyte/flytepropeller/pkg/controller/nodes/task/k8s"
@@ -206,7 +206,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 			if err != nil {
 				errMsg := fmt.Sprintf("Failed to validate literal type for [%s] with err: %s", key, err)
 				return handler.DoTransition(handler.TransitionTypeEphemeral,
-					handler.PhaseInfoFailure(idlcore.ExecutionError_USER, errors.IDLNotFoundErr, errMsg, nil),
+					handler.PhaseInfoFailure(idlcore.ExecutionError_USER, flyteErrors.IDLNotFoundErr, errMsg, nil),
 				), nil
 			}
 			if variable.GetOffloadedMetadata() != nil {
@@ -215,7 +215,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 				err := common.ReadLargeLiteral(ctx, nCtx.DataStore(), variable)
 				if err != nil {
 					return handler.DoTransition(handler.TransitionTypeEphemeral,
-						handler.PhaseInfoFailure(idlcore.ExecutionError_SYSTEM, errors.RuntimeExecutionError, "couldn't read the offloaded literal", nil),
+						handler.PhaseInfoFailure(idlcore.ExecutionError_SYSTEM, flyteErrors.RuntimeExecutionError, "couldn't read the offloaded literal", nil),
 					), nil
 				}
 			}
@@ -226,7 +226,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 					size = collectionLength
 				} else if size != collectionLength {
 					return handler.DoTransition(handler.TransitionTypeEphemeral,
-						handler.PhaseInfoFailure(idlcore.ExecutionError_USER, errors.InvalidArrayLength,
+						handler.PhaseInfoFailure(idlcore.ExecutionError_USER, flyteErrors.InvalidArrayLength,
 							fmt.Sprintf("input arrays have different lengths: expecting '%d' found '%d'", size, collectionLength), nil),
 					), nil
 				}
@@ -235,7 +235,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 
 		if size == -1 {
 			return handler.DoTransition(handler.TransitionTypeEphemeral,
-				handler.PhaseInfoFailure(idlcore.ExecutionError_USER, errors.InvalidArrayLength, "no input array provided", nil),
+				handler.PhaseInfoFailure(idlcore.ExecutionError_USER, flyteErrors.InvalidArrayLength, "no input array provided", nil),
 			), nil
 		}
 
@@ -546,7 +546,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 			taskNode, err := nCtx.ExecutionContext().GetTask(taskID)
 			if err != nil {
 				return handler.DoTransition(handler.TransitionTypeEphemeral, handler.PhaseInfoFailure(idlcore.ExecutionError_SYSTEM,
-					errors.BadSpecificationError, fmt.Sprintf("failed to find ArrayNode subNode task with id: '%s'", taskID), nil)), nil
+					flyteErrors.BadSpecificationError, fmt.Sprintf("failed to find ArrayNode subNode task with id: '%s'", taskID), nil)), nil
 			}
 
 			if outputs := taskNode.CoreTask().GetInterface().GetOutputs(); outputs != nil {
@@ -617,7 +617,7 @@ func (a *arrayNodeHandler) Handle(ctx context.Context, nCtx interfaces.NodeExecu
 			},
 		)), nil
 	default:
-		return handler.UnknownTransition, errors.Errorf(errors.IllegalStateError, nCtx.NodeID(), "invalid ArrayNode phase %+v", arrayNodeState.Phase)
+		return handler.UnknownTransition, flyteErrors.Errorf(flyteErrors.IllegalStateError, nCtx.NodeID(), "invalid ArrayNode phase %+v", arrayNodeState.Phase)
 	}
 
 	// if there were changes to subNode status then the eventRecorder will require finalizing to

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager_test.go

@@ -815,6 +815,7 @@ func TestPluginManager_Handle_PluginState(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+
 		t.Run(tt.name, func(t *testing.T) {
 			// mock TaskExecutionContext
 			tCtx := &pluginsCoreMock.TaskExecutionContext{}

flytestdlib/bitarray/bitset.go

@@ -48,7 +48,6 @@ func (s *BitSet) BlockCount() int {
 // Returns the length of the BitSet.
 func (s *BitSet) Cap() uint {
 	return uint(s.BlockCount()) * blockSize // #nosec G115
-
 }
 
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.

flytestdlib/bitarray/compact_array.go

@@ -45,10 +45,8 @@ func (a *CompactArray) SetItem(index int, value Item) {
 	for i := int(a.ItemSize - 1); i >= 0; i-- {
 		if x&value != 0 {
 			a.BitSet.Set(bitIndex + uint(i)) // #nosec G115
-
 		} else {
 			a.BitSet.Clear(bitIndex + uint(i)) // #nosec G115
-
 		}
 
 		x <<= 1

flytestdlib/bitarray/compact_array_test.go

@@ -92,7 +92,6 @@ func BenchmarkCompactArray_SetItem(b *testing.B) {
 
 	b.ResetTimer()
 	arr, err := NewCompactArray(itemsCount, Item(b.N)) // #nosec G115
-
 	assert.NoError(b, err)
 
 	for i := 0; i < b.N; i++ {
@@ -140,7 +139,6 @@ func TestPanicOnOversizedValue(t *testing.T) {
 	assert.Panics(t, func() { itemArray.validateValue(4) })
 	for i := 0; i < 4; i++ {
 		assert.NotPanics(t, func() { itemArray.validateValue(Item(i)) }) // #nosec G115
-
 	}
 }
 

flytestdlib/storage/copy_impl_test.go

@@ -2,14 +2,15 @@ package storage
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"math/rand"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 
-	"github.com/flyteorg/flyte/flytestdlib/errors"
+	flyteErrors "github.com/flyteorg/flyte/flytestdlib/errors"
 	"github.com/flyteorg/flyte/flytestdlib/ioutils"
 )
 
@@ -98,11 +99,11 @@ func TestCopyRaw_CachingErrorHandling(t *testing.T) {
 			ReadRawCb: func(ctx context.Context, reference DataReference) (closer io.ReadCloser, e error) {
 				readerCalled = true
 				//nolint:govet,staticcheck
-				return ioutils.NewBytesReadCloser(bigD), errors.Wrapf(ErrFailedToWriteCache, fmt.Errorf(dummyErrorMsg), "Failed to Cache the metadata")
+				return ioutils.NewBytesReadCloser(bigD), flyteErrors.Wrapf(ErrFailedToWriteCache, fmt.Errorf(dummyErrorMsg), "Failed to Cache the metadata")
 			},
 			WriteRawCb: func(ctx context.Context, reference DataReference, size int64, opts Options, raw io.Reader) error {
 				writerCalled = true
-				return errors.Wrapf(ErrFailedToWriteCache, fmt.Errorf(dummyErrorMsg), "Failed to Cache the metadata") //nolint:govet,staticcheck
+				return flyteErrors.Wrapf(ErrFailedToWriteCache, fmt.Errorf(dummyErrorMsg), "Failed to Cache the metadata") //nolint:govet,staticcheck
 			},
 		}
 

flytestdlib/storage/stow_store.go

@@ -446,7 +446,6 @@ const (
 
 func (l locationID) String() string {
 	return strconv.Itoa(int(l)) // #nosec G115
-
 }
 
 func (s *StowStore) getLocation(id locationID) stow.Location {