Rename --archive to --deactivate in update launchplan cmd

Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com>

clierrors/errors.go

@@ -2,6 +2,7 @@ package clierrors
 
 var (
 	ErrInvalidStateUpdate = "invalid state passed. Specify either activate or archive\n"
+	ErrInvalidBothStateUpdate = "invalid state passed. Specify either activate or deactivate\n"
 
 	ErrProjectNotPassed     = "project id wasn't passed\n" // #nosec
 	ErrProjectIDBothPassed  = "both project and id are passed\n"

cmd/config/subcommand/launchplan/updateconfig.go

@@ -7,8 +7,8 @@ var (
 
 // Config
 type UpdateConfig struct {
-	Archive  bool   `json:"archive" pflag:",disable the launch plan schedule (if it has an active schedule associated with it)."`
 	Activate bool   `json:"activate" pflag:",activate launchplan."`
+	Deactivate  bool   `json:"deactivate" pflag:",disable the launch plan schedule (if it has an active schedule associated with it)."`
 	DryRun   bool   `json:"dryRun" pflag:",execute command without making any modifications."`
 	Force    bool   `json:"force" pflag:",do not ask for an acknowledgement during updates."`
 	Version  string `json:"version" pflag:",version of the launchplan to be fetched."`

cmd/update/launch_plan.go

@@ -22,10 +22,10 @@ Activates a ` + "`launch plan <https://docs.flyte.org/projects/cookbook/en/lates
 
  flytectl update launchplan -p flytesnacks -d development core.control_flow.merge_sort.merge_sort --version v1 --activate
 
-Archives ` + "`(deactivates) <https://docs.flyte.org/projects/cookbook/en/latest/auto/core/scheduled_workflows/lp_schedules.html#deactivating-a-schedule>`__" + ` a launch plan which deschedules any scheduled job associated with it:
+Deactivates a ` + "`launch plan <https://docs.flyte.org/projects/cookbook/en/latest/auto/core/scheduled_workflows/lp_schedules.html#deactivating-a-schedule>`__" + ` which deschedules any scheduled job associated with it:
 ::
 
- flytectl update launchplan -p flytesnacks -d development core.control_flow.merge_sort.merge_sort --version v1 --archive
+ flytectl update launchplan -p flytesnacks -d development core.control_flow.merge_sort.merge_sort --version v1 --deactivate
 
 Usage
 `
@@ -44,15 +44,15 @@ func updateLPFunc(ctx context.Context, args []string, cmdCtx cmdCore.CommandCont
 	}
 
 	activate := launchplan.UConfig.Activate
-	archive := launchplan.UConfig.Archive
-	if activate == archive && archive {
-		return fmt.Errorf(clierrors.ErrInvalidStateUpdate)
+	deactivate := launchplan.UConfig.Deactivate
+	if activate == deactivate && deactivate {
+		return fmt.Errorf(clierrors.ErrInvalidBothStateUpdate)
 	}
 
 	var newState admin.LaunchPlanState
 	if activate {
 		newState = admin.LaunchPlanState_ACTIVE
-	} else if archive {
+	} else if deactivate {
 		newState = admin.LaunchPlanState_INACTIVE
 	}
 

cmd/update/launch_plan_test.go

@@ -35,11 +35,11 @@ func TestLaunchPlanCanBeActivated(t *testing.T) {
 		})
 }
 
-func TestLaunchPlanCanBeArchived(t *testing.T) {
+func TestLaunchPlanCanBeDeactivated(t *testing.T) {
 	testLaunchPlanUpdate(
 		/* setup */ func(s *testutils.TestStruct, config *launchplan.UpdateConfig, launchplan *admin.LaunchPlan) {
 			launchplan.Closure.State = admin.LaunchPlanState_ACTIVE
-			config.Archive = true
+			config.Deactivate = true
 			config.Force = true
 		},
 		/* assert */ func(s *testutils.TestStruct, err error) {
@@ -53,14 +53,14 @@ func TestLaunchPlanCanBeArchived(t *testing.T) {
 		})
 }
 
-func TestLaunchPlanCannotBeActivatedAndArchivedAtTheSameTime(t *testing.T) {
+func TestLaunchPlanCannotBeActivatedAndDeactivatedAtTheSameTime(t *testing.T) {
 	testLaunchPlanUpdate(
 		/* setup */ func(s *testutils.TestStruct, config *launchplan.UpdateConfig, launchplan *admin.LaunchPlan) {
 			config.Activate = true
-			config.Archive = true
+			config.Deactivate = true
 		},
 		/* assert */ func(s *testutils.TestStruct, err error) {
-			assert.ErrorContains(t, err, "Specify either activate or archive")
+			assert.ErrorContains(t, err, "Specify either activate or deactivate")
 			s.MockAdminClient.AssertNotCalled(t, "UpdateLaunchPlan", mock.Anything, mock.Anything)
 		})
 }