Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Update dependencies for Flyte monorepo migration #429

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Oct 6, 2023

TL;DR

See PR title

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1152c5f) 67.47% compared to head (b60bf87) 68.22%.

❗ Current head b60bf87 differs from pull request most recent head b910dd7. Consider uploading reports for the commit b910dd7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   67.47%   68.22%   +0.74%     
==========================================
  Files         147      147              
  Lines        6548     5450    -1098     
==========================================
- Hits         4418     3718     -700     
+ Misses       1839     1441     -398     
  Partials      291      291              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/compile/compile.go 86.66% <ø> (+2.75%) ⬆️
cmd/config/config.go 66.66% <ø> (ø)
...subcommand/clusterresourceattribute/file_config.go 86.66% <ø> (+4.31%) ⬆️
cmd/config/subcommand/config/console_flags.go 0.00% <ø> (ø)
...ig/subcommand/executionclusterlabel/file_config.go 86.66% <ø> (+4.31%) ⬆️
.../subcommand/executionqueueattribute/file_config.go 86.66% <ø> (+4.31%) ⬆️
...d/config/subcommand/plugin_override/file_config.go 86.66% <ø> (+4.31%) ⬆️
cmd/config/subcommand/project/project_config.go 73.80% <ø> (+2.90%) ⬆️
cmd/config/subcommand/register/files_config.go 0.00% <ø> (ø)
...ig/subcommand/taskresourceattribute/file_config.go 86.66% <ø> (+4.31%) ⬆️
... and 68 more

... and 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kamal Eybov <54046807+kamaleybov@users.noreply.github.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
@katrogan
Copy link
Contributor Author

ping @eapolinario is this okay to go in?

@eapolinario eapolinario merged commit 6485353 into master Oct 23, 2023
12 checks passed
@eapolinario eapolinario deleted the monorepo-itize branch October 23, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants