This repository has been archived by the owner on May 31, 2024. It is now read-only.
Feature: update launchplan --archive to --deactivate #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoundarya96
requested review from
kumare3,
EngHabu and
wild-endeavor
as code owners
asoundarya96
force-pushed
the
sa/4563
branch
from
070113f to
5752574
Compare
Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com>
asoundarya96
force-pushed
the
sa/4563
branch
from
99ef6ea to
5125b16
Compare
Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 67.69% 67.75% +0.05%
==========================================
Files 148 148
Lines 6622 6633 +11
==========================================
+ Hits 4483 4494 +11
Misses 1851 1851
Partials 288 288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@asoundarya96 , thanks for your contribution! Can we keep the |
Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com>
asoundarya96
changed the title
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Dec 26, 2023
eapolinario
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR resolves issue #4563
Renamed flag
--archiveto--deactivateof cmd -flytectl update launchplanType
Are all requirements met?
Tracking Issue
https://github.com/flyteorg/flyte/issues/