Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reservations controller #20

Merged
merged 13 commits into from
Feb 17, 2024
Merged

Conversation

M-Anwar-Hussaini
Copy link
Collaborator

@M-Anwar-Hussaini M-Anwar-Hussaini commented Feb 16, 2024

#Summary of this PR:

  • Add api controller for reservations for the following actions
    • index
    • show
    • destroy
    • update
    • create
  • Add some seed data to the seed.rb file.

Copy link
Collaborator

@Estete9 Estete9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M-Anwar-Hussaini
I'll review this PR. ✋

Good job so far it is looking almost perfect!
There are some recommendations I would like you to take into account.

Highlights
You have written a clean code ✅
The distribution, padding, and margins are perfect. ✅
Good PR title/description ✅
Required Changes ♻️
Good job adding the elements in the list in the main section, but we can improve it a little bit more together. 💪

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @Estete9 in your question so I can receive the notification. You can also follow me on the below platforms

@Estete9 linkedin-esteban-palacios-5030a772 @NaughTban

app/controllers/api/v1/reservations_controller.rb Outdated Show resolved Hide resolved
app/controllers/api/v1/reservations_controller.rb Outdated Show resolved Hide resolved
@fmanimashaun fmanimashaun merged commit bd4ab6a into dev Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants