-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reservations controller #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M-Anwar-Hussaini
I'll review this PR. ✋
Good job so far it is looking almost perfect!
There are some recommendations I would like you to take into account.
Highlights
You have written a clean code ✅
The distribution, padding, and margins are perfect. ✅
Good PR title/description ✅
Required Changes ♻️
Good job adding the elements in the list in the main section, but we can improve it a little bit more together. 💪
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
⚠️ WARNING ⚠️
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Have any doubt ❓
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @Estete9 in your question so I can receive the notification. You can also follow me on the below platforms
#Summary of this PR:
index
show
destroy
update
create