Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car listing frontend #16

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Car listing frontend #16

merged 7 commits into from
Feb 20, 2024

Conversation

tomasesquivelgc
Copy link
Collaborator

In this branch I:

  • Add styles to the home page
  • Display all cars in a carrousel in groups of 3
  • Add pagination for easy navigation
  • Change color palettes to match template
  • Add PNG icons to match template

Copy link
Collaborator

@Estete9 Estete9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomasesquivelgc ,

Your feature is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

STATUS: APPROVED 🟢

Highlights

  • Good PR title ✅
  • Descriptive PR description ✅
  • Implement the features ✅
  • Great use of modules ✅
  • Linters are green ✅
  • Meaningful Github commits ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @Estete9 in your question so I can receive the notification. You can also follow me on the below platforms

@Estete9 linkedin-esteban-palacios-5030a772 @NaughTban

@tomasesquivelgc tomasesquivelgc merged commit 2508113 into dev Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants