-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book a Car Frontend #34
Conversation
installed axios and updated plugins
reinstall linters
add linters.yml
Back-end integration
Backend integration update
Create routes to login and register that dont require RequireAuth component
…k-car into Estete9-authors
Estete9 authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
Tip
The issues seem to be related to aws authentication credentials whenever the app tries to save images.
This affected the seeds file (the very end of it when the images are saved) and the add car functionality (since it cannot save the images.).
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
Project requirements
BACKEND PR
NOTE
Please make sure of the follwoing:
.env
with the contentREACT_APP_BASE_URL=http://localhost:4000
exists in the app's root directoryBasics
Features
Depending on your team size you are required to complete a set number of features. Take inventory of your team and see where you fit in the following table:
If your team has finished the required features, but you'd still like to complete more you are free to continue with the optional ones.
Note: If your team decides to implement optional features, make sure they work as expected (just like the required ones). This will be considered in your final evaluation!
Core features - Required for every team size
The user logs in to the website, only by typing the username (a proper authenticated login is a requirement if your group is made of 5 people).
In the navigation panel, the user can see links to:
On the main page, the user can see a list of motorcycles/doctors/classes/items that you selected as a theme.
When the user selects a specific item, they can see the details page with its full description (skip the "Rotate image" button).
When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.
Make the app responsive, creating both mobile and desktop versions.
Additional features - Required for teams with 3-4 & 5 members (optional for others)
Additional features - Required only for teams with 5 members (optional for others)
Setup
Clone this repository to your desired folder:
Example commands:
cd my-folder git clone https://github.com/fmanimashaun/book-car.git
Install
Install this project's dependencies with:
Usage
To run the project, first, make sure you have these files in the project's root directory
.env
with this codeREACT_APP_BASE_URL=http://localhost:4000
Then execute the following command:
Runs the app in the development mode.
Open http://localhost:3000 to view it in your browser.