Fix bug with weekday option not working as expected when shift is enabled #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Nando,
Thank you for the wonderful gem, we have been using it for years and it's really useful.
@pmrazovic has noticed a bug with how it handles
weekday
option whenshift
is enabled, so this PR fixes it.We give users access to specify the rules for recurrence so we generally always want to enable
shift
.Without the fix these are the first three Recurrence events for
This is with the fix: