Improve getHoliday caching and improve ops/s
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derTobsch
force-pushed
the
benchmark
branch
4 times, most recently
from
9f23960 to
358796f
Compare
derTobsch
force-pushed
the
improve-caching
branch
4 times, most recently
from
485c0a6 to
fe0dc66
Compare
derTobsch
force-pushed
the
improve-caching
branch
from
fe0dc66 to
f6215a9
Compare
|
derTobsch
changed the title
getHoliday caching and improve ops/s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #460
With the cache mechanism moved from the
isHoliday(..)method to the basic methodgetHoliday(..)that is also used byisHoliday(..). We will get an nice performance boost from44437.257 ops/ssee https://github.com/focus-shift/jollyday/pull/474/checks
up to
23832222.693 ops/ssee https://github.com/focus-shift/jollyday/actions/runs/8111314784/job/22170341131
That means an improvement of
(23832222 - 44437) / 44437 * 100 = 53531 %