Secure Boot & Virtual TPM #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stejskalleos is this good to review? |
|
Yes, but I cannot say that 100% it's working as my provisioning was kinda funky when I was testing it. |
chris1984
reviewed
Jul 10, 2024
nofaralfasi
reviewed
Jul 16, 2024
Comment on lines
+172
to
+174
| if attributes[:secure_boot] | ||
| options[:efiSecureBootEnabled] = true | ||
| end |
There was a problem hiding this comment.
This won't work if boot_order or boot_retry are not set. See
|
I don't have permission to push changes to this PR, so I created a new one: #305. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Secure Boot and TPM
Inspired by https://github.com/ananace/foreman_vmware_advanced