Settings: Suppressed warning with the same shortcut for the same action

foldynl · Jun 20, 2024 · f20ecaf · f20ecaf
1 parent f243acc
commit f20ecaf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/models/ShortcutEditorModel.cpp b/models/ShortcutEditorModel.cpp
@@ -82,7 +82,7 @@ bool ShortcutEditorModel::setData(const QModelIndex &index, const QVariant &valu
             return false;
         }
 
-        if ( findShortcut(actionList, newShortcutString) )
+        if ( findShortcut(actionList, action, newShortcutString) )
         {
             emit conflictDetected(tr("Conflict with a user-defined shortcut"));
             return false;
@@ -109,11 +109,13 @@ Qt::ItemFlags ShortcutEditorModel::flags(const QModelIndex &index) const
 }
 
 const QAction *ShortcutEditorModel::findShortcut(const QList<QAction *> &list,
-                                                 const QString &shortcut)
+                                                 const QAction *currAction,
+                                                 const QString &shortcut) const
 {
     for ( const QAction* action : list )
     {
-        if ( action->shortcut().toString(QKeySequence::NativeText) == shortcut )
+        if ( action->shortcut().toString(QKeySequence::NativeText) == shortcut
+             && action != currAction )
             return action;
     }
 

diff --git a/models/ShortcutEditorModel.h b/models/ShortcutEditorModel.h
@@ -32,7 +32,8 @@ class ShortcutEditorModel : public QAbstractTableModel
     QStringList builtInStaticActionList;
 
     const QAction *findShortcut(const QList<QAction *> &list,
-                                const QString&);
+                                const QAction *currAction,
+                                const QString&) const;
 };
 
 #endif // SHORTCUTEDITORMODEL_H