Fix Clang/MSVC compile options handling #210
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with Lexy where it will fail to build on Windows using Clang with the GNU-like command-line.
This is due to the src/CMakeLists.txt#L180 using CMAKE_CXX_SIMULATE_ID for checking what compile options to add which does not reflect how the command line options are handled.
The CMAKE_CXX_COMPILER_FRONTEND_VARIANT variable has the correct information for determining this.
More information on detecting the differences between
clang
with the GNU-like command-line andclang-cl
with the MSVC-like command-line can be found in this CMake issue https://gitlab.kitware.com/cmake/cmake/-/issues/19724. It looks like these variables were undocumented for a while and only recently added to the CMake documentation.The changes in this PR should correctly handle Lexy being built using
clang
orclang-cl
on Windows.