From 174d51b4867c9cbeec00a2f8c26e4a7c54444476 Mon Sep 17 00:00:00 2001 From: Giordano Cardillo Date: Wed, 14 Feb 2018 09:35:10 +0100 Subject: [PATCH 1/3] Added return value to pageSize method --- src/js/components/paging/FooTable.Paging.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/components/paging/FooTable.Paging.js b/src/js/components/paging/FooTable.Paging.js index f9ebcbb0..ae38bfd2 100644 --- a/src/js/components/paging/FooTable.Paging.js +++ b/src/js/components/paging/FooTable.Paging.js @@ -425,7 +425,7 @@ * Gets or sets the current page size. * @instance * @param {(number|string)} [value] - The new page size to use, this value is supplied to `parseInt` so strings can be used. If not supplied or an invalid valid the current page size is returned. - * @returns {(number|undefined)} + * @returns {jQuery.Promise} */ pageSize: function(value){ value = parseInt(value); @@ -442,7 +442,7 @@ } } this.$create(); - this.ft.draw(); + return this.ft.draw(); }, /* PRIVATE */ From f9d6307af6acc5c95203ef0d01906dd207e0b4ae Mon Sep 17 00:00:00 2001 From: Giordano Cardillo Date: Wed, 14 Feb 2018 09:39:42 +0100 Subject: [PATCH 2/3] Edited jsdoc --- src/js/components/paging/FooTable.Paging.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/components/paging/FooTable.Paging.js b/src/js/components/paging/FooTable.Paging.js index ae38bfd2..890ca6f5 100644 --- a/src/js/components/paging/FooTable.Paging.js +++ b/src/js/components/paging/FooTable.Paging.js @@ -425,7 +425,7 @@ * Gets or sets the current page size. * @instance * @param {(number|string)} [value] - The new page size to use, this value is supplied to `parseInt` so strings can be used. If not supplied or an invalid valid the current page size is returned. - * @returns {jQuery.Promise} + * @returns {number|jQuery.Promise} */ pageSize: function(value){ value = parseInt(value); From f7be17d43a4585d9e14268f14237fcbac8175c04 Mon Sep 17 00:00:00 2001 From: Giordano Cardillo Date: Wed, 14 Feb 2018 09:40:42 +0100 Subject: [PATCH 3/3] Added braces to JSDoc --- src/js/components/paging/FooTable.Paging.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/components/paging/FooTable.Paging.js b/src/js/components/paging/FooTable.Paging.js index 890ca6f5..cd124110 100644 --- a/src/js/components/paging/FooTable.Paging.js +++ b/src/js/components/paging/FooTable.Paging.js @@ -425,7 +425,7 @@ * Gets or sets the current page size. * @instance * @param {(number|string)} [value] - The new page size to use, this value is supplied to `parseInt` so strings can be used. If not supplied or an invalid valid the current page size is returned. - * @returns {number|jQuery.Promise} + * @returns {(number|jQuery.Promise)} */ pageSize: function(value){ value = parseInt(value);