Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RewardBench script #6

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Add RewardBench script #6

merged 12 commits into from
Jul 8, 2024

Conversation

ljvmiranda921
Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 commented Jul 3, 2024 •
edited
Loading

@ljvmiranda921 ljvmiranda921 requested review from srishti-git1110 and sanggusti and removed request for srishti-git1110 and sanggusti July 3, 2024 17:29
@ljvmiranda921 ljvmiranda921 self-assigned this Jul 3, 2024
@sanggusti
Copy link
Member

Can you show us what is the output of scripts/convert_multilingual_uf.py before merging?

sanggusti
sanggusti requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@sanggusti sanggusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takeaways:

  • Add how to run the scripts/run_rewardbench.sh in README.md
  • We might need to use poetry to version our projects, the Dockerfile could follow
  • Also post the output of the running scripts as the reference

requirements.txt Show resolved Hide resolved
scripts/run_rewardbench.sh Show resolved Hide resolved
@sanggusti
Copy link
Member

Can you show us what is the output of scripts/convert_multilingual_uf.py before merging?

Oh I've just see it in Discord. Thanks LJ!
image

@sanggusti sanggusti self-requested a review July 4, 2024 02:37
sanggusti
sanggusti reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@sanggusti sanggusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a little more details in README.md on how to run the run_rewardbench.sh

@sanggusti sanggusti self-requested a review July 6, 2024 01:58
sanggusti
sanggusti approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@sanggusti sanggusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanggusti sanggusti merged commit 219fad6 into main Jul 8, 2024
1 check passed
@ljvmiranda921 ljvmiranda921 deleted the feat/rewardbench branch July 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanggusti sanggusti sanggusti approved these changes

@srishti-git1110 srishti-git1110 Awaiting requested review from srishti-git1110

Assignees

@ljvmiranda921 ljvmiranda921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljvmiranda921 @sanggusti