Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #203

Closed
wants to merge 6 commits into from
Closed

Maintenance #203

wants to merge 6 commits into from

Conversation

maurolepore
Copy link
Contributor

@maurolepore maurolepore commented Jan 26, 2024 •
edited
Loading

This PR fixes a parameter in an internal function to that triggers a warning with the in-development version of R.

CRAN requested the fix before mid Feb.

---------- Forwarded message ---------
From: Kurt Hornik <Kurt.Hornik@wu.ac.at>
Date: Mon, Jan 22, 2024 at 1:19 PM
Subject: CRAN package fgeo.tool
To: <maurolepore@gmail.com>
Cc: <CRAN@r-project.org>


Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_fgeo.tool.html>.

Specifically, pls see the Rd \usage sections check NOTEs.

Please correct before 2024-02-19 to safely retain your package on CRAN.

Best,
-k

Also while we're here:

  • Update version of roxygen2
  • Spellcheck
  • Update usage of tidyselect expression

@maurolepore
Fix wrong param
05999b8 
This responds to a request by CRAN

W  checking Rd \usage sections ...
   Undocumented arguments in documentation object 'recode_subquad'
     ‘data’
   Documented arguments not in \usage in documentation object 'recode_subquad':
     ‘x’
@maurolepore
Update version of roxygen2
74efc63
@maurolepore
Spellcheck
6c78889
@maurolepore
Update usage of tidyselect expression
c16d387
@maurolepore maurolepore marked this pull request as ready for review January 27, 2024 00:31
@maurolepore maurolepore requested a review from teixeirak January 27, 2024 00:39
@maurolepore
Export methods
35f2a7c 
Avoids the following during R CMD check:

```
ℹ Loading fgeo.tool
✖ fgeo_elevation.R:83: S3 method `pull_elevation.default` needs @export or
  @exportS3method tag.
✖ fgeo_elevation.R:90: S3 method `pull_elevation.list` needs @export or @exportS3method
  tag.
✖ fgeo_elevation.R:78: S3 method `pull_elevation.data.frame` needs @export or
  @exportS3method tag.
```
@maurolepore
Build README
d321e9e
@maurolepore
Copy link
Contributor Author

fgeo.tool 1.2.9 is now on CRAN
https://github.com/maurolepore/fgeo.tool

The changes are available at https://github.com/maurolepore/fgeo.tool

@maurolepore maurolepore deleted the fix-param branch January 27, 2024 23:04
@teixeirak
Copy link
Member

Many thanks, @maurolepore !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teixeirak teixeirak Awaiting requested review from teixeirak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolepore @teixeirak