WIP - Modernized but working externally in 3.24 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, rename a few things for clarity, move some component templates
…ming, remove unnecessary @Tracked;5C vars, hook up web of render hooks
…ections were being swallowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks to the modernize branch that allow it to work in Nirvana on Ember 3.24.
The current state is that it loads correctly, and more reports work correctly than if we were running the master ember-printable-pages branch, but there are a few reports that are still 'flickering'. Those that are still flickering are mostly reports where each item is meant to take up a half page or a full page.
I also have this PR directly onto Jeff's modernize branch, which is might be the preferable one to merge. If so, this PR is for visibility.