From b465b2111e08e063efeba50b39b2f152da14ab3e Mon Sep 17 00:00:00 2001 From: Jeffrey Biles Date: Sun, 28 May 2023 18:16:33 -0500 Subject: [PATCH 1/3] Bugfix: allow unit args --- addon/components/printable-pages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/components/printable-pages.js b/addon/components/printable-pages.js index 297e3bd..df095b1 100644 --- a/addon/components/printable-pages.js +++ b/addon/components/printable-pages.js @@ -61,7 +61,7 @@ export default class PrintablePagesComponent extends Component { } get pageLayout() { - let units = isBlank(this.units) ? DEFAULT_DIMENSIONS.units : this.units; + let units = isBlank(this.args.units) ? DEFAULT_DIMENSIONS.units : this.units; let width = getOrDefault(this.args, "dimensions", "width"); let height = getOrDefault(this.args, "dimensions", "height"); let top = getOrDefault(this.args, "margins", "top"); From b1b802a0f7502a57673ce6d5018169c0dc4d7faf Mon Sep 17 00:00:00 2001 From: Jeffrey Biles Date: Sun, 28 May 2023 18:36:37 -0500 Subject: [PATCH 2/3] Add unit args to both spots --- addon/components/printable-pages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addon/components/printable-pages.js b/addon/components/printable-pages.js index df095b1..e464a36 100644 --- a/addon/components/printable-pages.js +++ b/addon/components/printable-pages.js @@ -61,7 +61,7 @@ export default class PrintablePagesComponent extends Component { } get pageLayout() { - let units = isBlank(this.args.units) ? DEFAULT_DIMENSIONS.units : this.units; + let units = isBlank(this.args.units) ? DEFAULT_DIMENSIONS.units : this.args.units; let width = getOrDefault(this.args, "dimensions", "width"); let height = getOrDefault(this.args, "dimensions", "height"); let top = getOrDefault(this.args, "margins", "top"); From 925aec4aacb8733db2401bfd8272ec1c450e623f Mon Sep 17 00:00:00 2001 From: Jeffrey Biles Date: Sun, 4 Jun 2023 07:29:10 -0500 Subject: [PATCH 3/3] Try doing same thing as getOrDefault --- addon/components/printable-pages.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/addon/components/printable-pages.js b/addon/components/printable-pages.js index e464a36..c980a29 100644 --- a/addon/components/printable-pages.js +++ b/addon/components/printable-pages.js @@ -61,7 +61,10 @@ export default class PrintablePagesComponent extends Component { } get pageLayout() { - let units = isBlank(this.args.units) ? DEFAULT_DIMENSIONS.units : this.args.units; + let units = get(this.args, 'units'); + if(isBlank(units)) { + units = DEFAULT_DIMENSIONS['units']; + } let width = getOrDefault(this.args, "dimensions", "width"); let height = getOrDefault(this.args, "dimensions", "height"); let top = getOrDefault(this.args, "margins", "top");