Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/fenix/123.1.0' into iceraven
Browse files Browse the repository at this point in the history
  • Loading branch information
akliuxingyuan committed Mar 11, 2024
2 parents ef3f5ab + 4b28245 commit 2d29c7d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ class FirefoxSuggestTest {
}

// TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348374
@Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035")
@SmokeTest
@Test
fun verifyFirefoxSuggestNonSponsoredSearchResultsTest() {
Expand All @@ -218,6 +219,7 @@ class FirefoxSuggestTest {
}

// TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348375
@Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035")
@Test
fun verifyFirefoxSuggestNonSponsoredSearchResultsWithPartialKeywordTest() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
Expand All @@ -237,6 +239,7 @@ class FirefoxSuggestTest {
}

// TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/2348376
@Ignore("Failing, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1882035")
@Test
fun openFirefoxSuggestNonSponsoredSearchResultsTest() {
runWithCondition(TestHelper.appContext.settings().enableFxSuggest) {
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/org/mozilla/fenix/HomeActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -483,8 +483,8 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity {
var maxDurationReached = false
val delay = FxNimbus.features.splashScreen.value().maximumDurationMs.toLong()
splashScreen.setKeepOnScreenCondition {
val dataFetched = components.settings.utmParamsKnown &&
components.settings.nimbusExperimentsFetched
val dataFetched = components.settings.nimbusExperimentsFetched

val keepOnScreen = !maxDurationReached && !dataFetched
if (!keepOnScreen) {
SplashScreen.firstLaunchExtended.record(
Expand Down

0 comments on commit 2d29c7d

Please sign in to comment.