Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use slack webhook from environment #87

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

przechrzta-f3
Copy link
Contributor

@przechrzta-f3 przechrzta-f3 commented Jun 6, 2024

Changes:

  • removed slack_webhook_secret from GitubTeamApprover configuration
  • removed encryption function and utilities around encryption
  • read SLACK_WEBHOOK_SECRET from environment and use for alerting

Context: ticket

Proof of work

Used local setup as described here
Tested on form3tech-lab
Test Pull Request: https://github.com/form3tech-lab/gta-testing-repository/pull/5

@przechrzta-f3 przechrzta-f3 requested a review from a team as a code owner June 6, 2024 10:16
@przechrzta-f3 przechrzta-f3 marked this pull request as draft June 6, 2024 10:17
@przechrzta-f3 przechrzta-f3 marked this pull request as ready for review June 10, 2024 13:31
Copy link

@wojciecholszewski-form3 wojciecholszewski-form3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@przechrzta-f3 przechrzta-f3 merged commit 5961574 into master Jun 10, 2024
1 check passed
@przechrzta-f3 przechrzta-f3 deleted the wp-slack-webhook branch June 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants