Improve cli abstractions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `Cmdliner.Arg.file` conv to parse valid files. Cmdliners' file conv already does a `Sys.file_exists` so we avoid code duplication here. Also define `Mode.t` as an algebraic datatype to reduce string allocations and allow for faster instant `is_` mode checks.
|
Merging to fix the CI in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Cmdliner.Arg.fileconv to parse valid files. Cmdliners' file conv already does aSys.file_existsso we avoid code duplication here.Also define
Mode.tas an algebraic datatype to reduce string allocations and allow for faster instantis_mode checks.In a separate PR I'll try to fix CI as well.
PS: My editor removes trailing white space. So, sorry for the big diff! The only relevant changes are in
main.mlin the bottom andmode.ml.