Make installation more portable #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this patch I make two significant changes: First, I use the installed dune `dt` binary to calculate the dependencyTree of a Node.js module. This change is accompanied by introduction of the `Bos` library to call subprocesses in a more declarative manner. The big change above assumes that the `dt` was installed correctly in the change introduced in 3516167. This commit requires `npm` to be configured correctly. Here I add the `conf-npm` package to try and do this automatically, but some systems may require more manual configuration. Regardless, if compilation succeeds then everything will be ok. Lastly, I create a `share/config` site for the `ast_gen` package to install the default `config.json` file. This extension makes the installation more portable as sites are managed by dune, and are configured in the `Auxiliary.Share` module.
|
I'm merging as it's passing the CI. I don't think I broke anything, but let's see 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch I make two significant changes:
First, I use the installed dune
dtbinary to calculate the dependencyTree of a Node.js module. This change is accompanied by introduction of theBoslibrary to call subprocesses in a more declarative manner.The big change above assumes that the
dtwas installed correctly in the change introduced in 3516167. This commit requiresnpmto be configured correctly. Here I add theconf-npmpackage to try and do this automatically, but some systems may require more manual configuration. Regardless, if compilation succeeds then everything will be ok.Lastly, I create a
share/configsite for theast_genpackage to install the defaultconfig.jsonfile. This extension makes the installation more portable as sites are managed by dune, and are configured in theAuxiliary.Sharemodule.