Changes from bringup with daisy-chain bus #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this build in the first place for daisy-chain, changed how the templating is implemented to make the code buildable.
See here for my main reference: https://stackoverflow.com/questions/495021/why-can-templates-only-be-implemented-in-the-header-file
Added Mute/Unmute discharge commands.
Switched to non-blocking wait for conversion, since conversion times are always greater than 1ms. I only changed this for the daisy chain files, but this may be desirable for addressed.
Wake up for daisy goes for an extra cycle, if I remember correctly this was necessary to wake up the whole bus.
Fixed the hex value for StartCombinedCellVoltageGpioConversion.
Reversed the data order for writing to the bus, since when writing, the first data that gets sent goes to the final chip, as opposed to reading, where the first chip's data comes out first.