Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [install] section to fpm.toml #906

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

moriglia
Copy link
Contributor

@moriglia moriglia commented Dec 10, 2024

Moved PR from stdlib-fpm to master branch.

Initial discussion here: #903

@moriglia
Copy link
Contributor Author

Another thing I noticed is that fpm will use the project name in the library archive, i.e. stdlib.
In contrast, in this section of the README, the suggested flag and name is fortran_stdlib.

Should I also change the project name to fortran_stdlib to have fpm produce libfortran_stdlib.a instead of libstdlib.a?

Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @moriglia.

Regarding the fpm library name, I believe it should remain stdlib, because that is the name that is typically used as a fpm dependency (including as a "metapackage").

fpm.toml Outdated Show resolved Hide resolved
@moriglia
Copy link
Contributor Author

Thank you! @perazz
Somehow it felt wrong to link against a fortran_stdlib to me, also :)

README.md Outdated Show resolved Hide resolved
@moriglia
Copy link
Contributor Author

moriglia commented Dec 15, 2024 via email

@jalvesz
Copy link
Contributor

jalvesz commented Dec 17, 2024

I think this PR can be merged. Let's wait a couple of days and if there are no remarks I'll merge it.

@jalvesz jalvesz merged commit 35e7146 into fortran-lang:master Dec 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants