Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix speaker UI broken and remove sso login with customer account #230

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Oct 30, 2024

This PR solves issue speaker UI got broken due to sync commits from upstream, and remove feature login with customer account as customer feature is removed from tickets system.

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Fix the broken speaker UI by removing conflicting CSS styles and eliminate the SSO login feature with customer accounts due to the removal of the customer feature.

Bug Fixes:

  • Fix the broken speaker UI by removing conflicting CSS styles.

Enhancements:

  • Remove the SSO login feature with customer accounts as the customer feature is no longer supported.

Copy link

sourcery-ai bot commented Oct 30, 2024

Reviewer's Guide by Sourcery

This PR removes the broken speaker UI components and eliminates the SSO login functionality for customer accounts. The changes primarily involve removing CSS styles related to the schedule header and navigation, as well as removing the customer account login integration from the authentication template.

Class diagram for the removal of SSO login functionality

classDiagram
    class AuthTemplate {
        - Eventyay-Ticket SSO login button
    }
    note for AuthTemplate "The Eventyay-Ticket SSO login button has been removed."
Loading

File-Level Changes

Change Details Files
Remove schedule header and navigation styles from the agenda CSS
  • Remove schedule-header flex container styles
  • Remove color contrast calculation functions and mixins
  • Remove schedule navigation component styles
  • Remove header-right component styles
src/pretalx/static/agenda/css/_agenda.css
Remove customer account SSO login functionality
  • Remove the Eventyay ticket login button and related conditional logic
  • Remove social app existence check template logic
src/pretalx/common/templates/common/auth.html
src/pretalx/common/templatetags/socialapp_extras.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more details about what specifically broke in the speaker UI and how removing these CSS styles fixes the issue. Consider splitting the CSS changes into a separate PR from the authentication changes.
  • The removal of SSO login functionality should include tests to verify the remaining authentication flows still work correctly.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@odkhang odkhang requested a review from mariobehling October 30, 2024 03:22
@mariobehling mariobehling merged commit a6dc697 into fossasia:development Oct 30, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants