Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup platform customization tutorial #557

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Cleanup platform customization tutorial #557

merged 2 commits into from
Jul 11, 2023

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Jul 6, 2023

Simplified language and applied style guide rules.

This commit addresses FFTK-2516
This commit applies to FFTK-2510
This commit applies to FFTK-988

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

cleanup!

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

I guess this also applies to FFTK 2430!

@kprosise kprosise requested review from angolini, vanmaegima and a team July 6, 2023 12:47
@doanac
Copy link
Member

doanac commented Jul 6, 2023

Docs for cdf41f1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2253/docs/artifacts/html/index.html

@doanac
Copy link
Member

doanac commented Jul 7, 2023

Docs for 747ea91 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2255/docs/artifacts/html/index.html

angolini
angolini approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions only
LGTM

source/tutorials/customizing-the-platform/cloning-meta-sub-repository.rst Outdated Show resolved Hide resolved
source/tutorials/customizing-the-platform/commit-and-push-recipe.rst Outdated Show resolved Hide resolved
source/tutorials/customizing-the-platform/commit-and-push-recipe.rst Outdated Show resolved Hide resolved
source/tutorials/customizing-the-platform/customizing-the-platform.rst Show resolved Hide resolved
source/tutorials/customizing-the-platform/enabling-recipe.rst Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Jul 7, 2023

Docs for 18a1d1b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2259/docs/artifacts/html/index.html

@kprosise
Cleanup platform customization tutorial
1c2c548 
Simplified language and applied style guide rules.

This commit addresses FFTK-2516
This commit applies to FFTK-2510
This commit applies to FFTK-988

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise force-pushed the cleanup-customizing-platform-tutorial branch from 18a1d1b to 1c2c548 Compare July 7, 2023 14:46
@doanac
Copy link
Member

doanac commented Jul 11, 2023

Docs for 85b7192 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2268/docs/artifacts/html/index.html

@kprosise kprosise merged commit 88d6cdd into foundriesio:main Jul 11, 2023
1 check passed
@kprosise kprosise deleted the cleanup-customizing-platform-tutorial branch July 11, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angolini angolini angolini approved these changes

@vanmaegima vanmaegima Awaiting requested review from vanmaegima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kprosise @doanac @angolini