-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup working with tags tutorial #558
Conversation
Docs for 49a0891 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2254/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
source/tutorials/working-with-tags/working-with-tags-summary.rst
Outdated
Show resolved
Hide resolved
and generate a new **Target** tagged with ``devel``. As a result, devices following | ||
``devel`` will update to the latest **Target**. | ||
Whenever you change the ``devel`` branch, FoundriesFactory® CI will build and generate a new Target tagged with ``devel``. | ||
As a result, devices following ``devel`` will update to the latest Target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed it, but since the repository won't have a devel branch, should we just have this whole thing set to for the main
branch instead?
Also - for wording, I think "change the devel branch" is confusing - For a minute I thought we were saying something different. Maybe "When you push changes to the branch..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see below you talk about setting up a devel branch now. I guess the bigger question is: "Do we want to force devel upon people to get started?". I thought the answer was "no" and we just want to get people up to speed making changes directly on main.
If we want them on devel - i can change the factory setup to include rules for a devel branch. Maybe we need @mike-scott to weigh in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-scott @rsalveti @doanac Do we have a decision on this for v91? To clarify/restate:
- This will be proceeded by a new tutorial on creating a new branch, but that won't be ready for this release
- In the meantime, there is a bit of a disclaimer on this tutorial that it will require creating a devel branch first, I can expand on that a bit
- We can pull this tutorial for now and reintroduce it once the branching tutorial is ready, or we can keep it as it is in this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it makes sense. this whole article is about working with tags.
Docs for c9b8452 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2263/docs/artifacts/html/index.html |
Docs for 777db48 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2264/docs/artifacts/html/index.html |
Docs for 92bb267 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2267/docs/artifacts/html/index.html |
Tutorial edited for simplification and style guide. Additional changes were needed to reflect the introduction of fast first Target in v91. As this change means there are no longer devel and master branches, much of this tutorial needed to be modified. Information was added pointing to the reference manual page on having the CI follow branches. This is a stop-gap measure until an additional tutorial is added which will focus on adding an additional branch. At that point, this tutorial will be revised again. QA steps: ran linter, checked output in browser. This commit addresses FFTK-2517 This commit applies to FFTK-2510 This commit applies to FFTK-2430 This commit applies to FFTK-988 Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
92bb267
to
b301cc1
Compare
Docs for b301cc1 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2269/docs/artifacts/html/index.html |
Tutorial edited for simplification and style guide. Additional changes were needed to reflect the introduction of fast first Target in v91. As this change means there are no longer devel and master branches, much of this tutorial needed to be modified. Information was added pointing to the reference manual page on having the CI follow branches. This is a stop-gap measure until an additional tutorial is added which will focus on adding an additional branch. At that point, this tutorial will be revised again.
QA steps: ran linter, checked output in browser.
This commit addresses FFTK-2517
This commit applies to FFTK-2510
This commit applies to FFTK-2430
This commit applies to FFTK-988
Readiness
Overview
Oy.
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
See commit message...this tutorial is going to be a bit awkward until we add an additional one, I tried to make it work out as best as possible for the time being, but suggestions are very welcome.