Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing getting started order for V92 FFT. #561

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Changing getting started order for V92 FFT. #561

merged 2 commits into from
Jul 14, 2023

Conversation

munoz0raul
Copy link
Member

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@munoz0raul
GS: Changing Installing fioclt order
deb21c7 
Now with FFT there is not need to install fioctl and set-up git before
registering a device.
@munoz0raul
GS: Adding picture showing device
646a5eb 
Add a picture to show the device on app.foundries.io instead
of suggesting the fioctl command. Fioctl installation and use
will be covered later in the docs.
@munoz0raul munoz0raul requested a review from kprosise July 13, 2023 18:47
@doanac
Copy link
Member

doanac commented Jul 13, 2023

Docs for 646a5eb are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2270/docs/artifacts/html/index.html

munoz0raul added a commit to munoz0raul/docs that referenced this pull request Jul 13, 2023
@munoz0raul
GS: Adding Section to Deploy app in the GS
6e30481 
This PR just make sense after merging foundriesio#561
@munoz0raul munoz0raul mentioned this pull request Jul 13, 2023
Merged
19 tasks
kprosise
kprosise approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! YOU ROCK!

@kprosise kprosise merged commit a22a65d into foundriesio:main Jul 14, 2023
1 check passed
munoz0raul added a commit to munoz0raul/docs that referenced this pull request Jul 14, 2023
@munoz0raul
GS: Adding Section to Deploy app in the GS
176a6c2 
This PR just make sense after merging foundriesio#561
kprosise pushed a commit that referenced this pull request Jul 14, 2023
@munoz0raul @kprosise
GS: Adding Section to Deploy app in the GS
59fe622 
This PR just make sense after merging #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprosise kprosise kprosise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munoz0raul @doanac @kprosise