Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to QEMU section for flashing #571

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

kprosise
Copy link
Contributor

Links were added in two places:

  • flashing instructions in admonition box which had previously only linked to supported boards
  • x86 board page in a new "see also" admonition

QA steps: checked links, viewed rendered output to check for visual errors.

This commit addresses FFTK-2618
This commit applies to FFTK-2619

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Addresses some post v91 feedback

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

@doanac
Copy link
Member

doanac commented Jul 21, 2023

@doanac
Copy link
Member

doanac commented Jul 21, 2023

@doanac
Copy link
Member

doanac commented Jul 21, 2023

source/getting-started/flash-device/index.rst Outdated Show resolved Hide resolved
Links were added in two places:
- flashing instructions in admonition box which had previously only
  linked to supported boards
- x86 board page in a new "see also" admonition

QA steps: checked links, viewed rendered output to check for visual
errors.

This commit addresses FFTK-2618
This commit applies to FFTK-2619

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@doanac
Copy link
Member

doanac commented Jul 24, 2023

@doanac
Copy link
Member

doanac commented Jul 24, 2023

@kprosise kprosise merged commit 4b67547 into foundriesio:main Jul 25, 2023
1 check failed
@kprosise kprosise deleted the links-to-qemu-flashing branch July 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants