Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information on qcow2 artifact #573

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add information on qcow2 artifact #573

merged 1 commit into from
Jul 25, 2023

Conversation

kprosise
Copy link
Contributor

Additional information was added to explicitly let readers know where the resizable images can be located. A typo was fixed, and a note on artifact names was also added.

QA steps: Checked rendered html

This addresses FFTK-2617

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

@kprosise
Add information on qcow2 artifact
88b6d6c 
Additional information was added to explicitly let readers know where
the resizable images can be located. A typo was fixed, and a note on
artifact names was also added.

QA steps: Checked rendered html

This addresses FFTK-2617

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from doanac, ricardosalveti and a team July 21, 2023 15:00
@doanac
Copy link
Member

doanac commented Jul 21, 2023

Docs for 88b6d6c are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2287/docs/artifacts/html/index.html

@kprosise kprosise merged commit d834379 into foundriesio:main Jul 25, 2023
1 check passed
@kprosise kprosise deleted the qemu-qcow2-artifact-location branch January 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardosalveti ricardosalveti ricardosalveti left review comments

@doanac doanac doanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kprosise @doanac @ricardosalveti