Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(QEMU - Arm64) clarify artefacts available and used #602

Merged

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 20, 2023

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

It was not clear to me where could I get the flash.bin
Also, not all arc images will have the flash.bin.

Example:

Screenshot 2023-09-20 at 18 31 45

Therefore, this PR propose adding a note to try to clarify and provide as an example a command that can work in those cases.

Screenshot 2023-09-20 at 18 29 29

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@camilamacedo86 camilamacedo86 changed the title (qemu run command and artefacts) clarify artefacts available and used (QEMU - Arm64) clarify artefacts available and used Sep 20, 2023
@doanac
Copy link
Member

doanac commented Sep 20, 2023

@kprosise kprosise merged commit 056775d into foundriesio:main Sep 21, 2023
3 checks passed
@camilamacedo86 camilamacedo86 deleted the clarify-artefacts-arm64-qemu branch September 22, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants