Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup reference-manual qemu section #626

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Cleanup reference-manual qemu section #626

merged 1 commit into from
Nov 9, 2023

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Nov 8, 2023

As the QEMU section had been cleaned up as parts of previous commits, the focus here was to address any outstanding issues. the qcow2 artifact was reported to no longer be available, so the instructions were updated to reflect this.

Output was checked in the browser.

This commit addresses FFTK-2793
This commit applies to FFTK-2732
This commit applies to FFTK 2731

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@kprosise
Cleanup reference-manual qemu section
61e1f7b 
As the QEMU section had been cleaned up as parts of previous commits,
the focus here was to address any outstanding issues.
the qcow2 artifact was reported to no longer be available, so the
instructions were updated to reflect this.

Output was checked in the browser.

This commit addresses FFTK-2793
This commit applies to FFTK-2732
This commit applies to FFTK 2731

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@doanac
Copy link
Member

doanac commented Nov 8, 2023

Docs for 61e1f7b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2479/docs/artifacts/html/index.html

camilamacedo86
camilamacedo86 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems great for me 🥇

@kprosise kprosise merged commit 1c4ee61 into foundriesio:main Nov 9, 2023
2 of 3 checks passed
@kprosise kprosise deleted the cleanup-qemu branch November 9, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angolini angolini angolini approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@vanmaegima vanmaegima Awaiting requested review from vanmaegima

@caiotpereira caiotpereira Awaiting requested review from caiotpereira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kprosise @doanac @angolini @camilamacedo86