-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup reference manual lmp section #633
Conversation
Docs for bcbe4e6 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2499/docs/artifacts/html/index.html |
Docs for c396726 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2500/docs/artifacts/html/index.html |
Docs for 1839524 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2501/docs/artifacts/html/index.html |
1839524
to
d1c1870
Compare
Docs for d1c1870 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2502/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor suggestions, otherwise it's a LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions from feedback
`reference-manual/linux` pages were checked and edited for grammar, spelling, and style. Pages which were a better fit for the user-guide were relocated under lmP Customization; an index page for that section was also added. Cleanup and possible relocation of linux-updating was skipped to avoid merge conflicts. Redirects added for moved pages. QA steps: checked rendered html. Ran linter within editor. Ran linkcheck. No issues to report, however this is a relatively large commit. This commit addresses FFTK 2791 This commit addresses FFTK 1887 This commit addresses FFTK 1741 This commit addresses FFTK 1681 This commit applies to FFTK 1687 This commit applies to FFTK 2730 This commit applies to FFTK 2732 This commit applies to FFTK 2731 This commit applies to FFTK 1702 This commit applies to FFTK 988 This commit applies to FFTK 2733 Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
ac61175
to
8998943
Compare
Docs for 8998943 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2505/docs/artifacts/html/index.html |
reference-manual/linux
pages were checked and edited for grammar, spelling, and style.Pages which were a better fit for the user-guide were relocated under lmP Customization; an index page for that section was also added.
Cleanup and possible relocation of linux-updating was skipped to avoid merge conflicts.
Redirects added for moved pages.
QA steps: checked rendered html. Ran linter within editor. Ran linkcheck. No issues to report, however this is a relatively large commit.
This commit addresses FFTK 2791
This commit addresses FFTK 1887
This commit addresses FFTK 1741
This commit addresses FFTK 1681
This commit applies to FFTK 1687
This commit applies to FFTK 2730
This commit applies to FFTK 2732
This commit applies to FFTK 2731
This commit applies to FFTK 1702
This commit applies to FFTK 988
This commit applies to FFTK 2733
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
This is a pretty large commit. Following cleanup commits will be a touch more atomic. For those reviewing, feel free to only review changes on pages/subjects you are familiar with.