Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-guide: additional config for lmp-device-auto-register #666

Merged
merged 1 commit into from
Jan 23, 2024
Merged

user-guide: additional config for lmp-device-auto-register #666

merged 1 commit into from
Jan 23, 2024

Conversation

mwasilew
Copy link
Contributor

lmp-device-auto-register script can register device with additional tags and using HSM. This patch describes how to use these options.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

lmp-device-auto-register script can register device with additional tags and using HSM. This patch describes how to use these options.

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

@doanac
Copy link
Member

doanac commented Jan 19, 2024

Docs for 299d2cb are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2570/docs/artifacts/html/index.html

kprosise
kprosise approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, otherwise it LGTM.

source/user-guide/lmp-device-auto-register/lmp-device-auto-register.rst Outdated Show resolved Hide resolved
source/user-guide/lmp-device-auto-register/lmp-device-auto-register.rst Outdated Show resolved Hide resolved
source/user-guide/lmp-device-auto-register/lmp-device-auto-register.rst Outdated Show resolved Hide resolved
ricardosalveti
ricardosalveti approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (technical side)

@mwasilew
user-guide: additional config for lmp-device-auto-register
2351464 
lmp-device-auto-register script can register device with additional tags
and using HSM. This patch describes how to use these options.

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@foundries.io>
@doanac
Copy link
Member

doanac commented Jan 23, 2024

Docs for 2351464 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2572/docs/artifacts/html/index.html

@kprosise kprosise merged commit 36dc959 into foundriesio:main Jan 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardosalveti ricardosalveti ricardosalveti approved these changes

@kprosise kprosise kprosise approved these changes

@StealthyCoder StealthyCoder Awaiting requested review from StealthyCoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwasilew @doanac @ricardosalveti @kprosise