-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ug: offline-update: Enable App fetching instead of preloading #694
Conversation
The recent changes to `ci-scripts` and `fioctl` allows offline update enabling without turning on the preloading/assembling. Signed-off-by: Mike Sul <mike.sul@foundries.io>
Docs for 6805a3b are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2638/docs/artifacts/html/index.html |
The provided mechanism will work only for the I am not sure if we should mention a specific version of |
@vanmaegima @caiotpereira Please, let me know if this change makes sense to you? This change won't impact existing customers that already turned on the preloading/assemble run to enable offline update (required in order to download apps into an offline bundle). The logic in the fioctl command is smart enough to figure out where to pull apps from. The goal is to guide new customers to use the new factory configuration parameter Also, the existing customers that use just offline update and do not need the image assembling/preloading can switch to this way. It will reduce a CI build duration for them because the assemble run is turned off in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mike-sul , this makes sense
@vanmaegima @caiotpereira This has been deployed to the prod, so the doc update can be merged now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, proceeding with merging
The recent changes to
ci-scripts
andfioctl
allows offline update enabling without turning on the preloading/assembling.PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.